ZEVA-1744: Unit tests for 3 supplementary components #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jdtoombs
commented
Dec 11, 2024
| coverageReporters: ['json'], | ||
| testEnvironment: "jest-environment-jsdom", | ||
| collectCoverageFrom: ["src/**/*.{js,jsx}"], | ||
| coverageReporters: ["json", "html", "lcov"], |
There was a problem hiding this comment.
Get visual representation of code coverage on local
jdtoombs
commented
Dec 11, 2024
| }, | ||
| coveragePathIgnorePatterns: ['node_modules/'], | ||
| testPathIgnorePatterns: ["/node_modules/", "/__tests__/test-data/"], |
There was a problem hiding this comment.
can have test-data folders in any __tests__ dir now
jdtoombs
commented
Dec 11, 2024
| @@ -64,7 +64,8 @@ | |||
| "@storybook/addon-storyshots": "^6.1.21", | |||
| "@storybook/react": "^6.1.21", | |||
| "@testing-library/jest-dom": "^4.2.4", | |||
| "@testing-library/react": "^9.4.0", | |||
| "@testing-library/react": "^10.0.0", | |||
There was a problem hiding this comment.
Upgraded version to get some more utility; however, could not upgrade to latest due to being on React v16
jdtoombs
commented
Dec 11, 2024
| @@ -64,7 +64,8 @@ | |||
| "@storybook/addon-storyshots": "^6.1.21", | |||
| "@storybook/react": "^6.1.21", | |||
| "@testing-library/jest-dom": "^4.2.4", | |||
| "@testing-library/react": "^9.4.0", | |||
| "@testing-library/react": "^10.0.0", | |||
| "@testing-library/user-event": "^14.5.2", | |||
There was a problem hiding this comment.
Good for testing uploads
tim738745
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket was to improve coverage for our supplementary components.
The 3 components that now have tests allocated to them are: